[Mythnettv] Patch

[Michael Still]

Michael Still wrote:
> James Purser wrote:
>> Hi all,
>>
>> Attached is a patch I knocked up this morning to make mythnettv query
>> myths own "videotypes" table to determine if the downloaded media file
>> needs to be converted.
>>
>> I've also put in a check for the urls call to test if there are enough
>> arguments passed, and if not will post a warning instead of dumping a
>> traceback. This needs to be done for most of flags I think.
> 
> Thanks for the patch! The long term goal is to have only command line
> parsing in the file named "mythnettv", and then have a core API which is
> uses to do anything. We're not there yet though.
> 
> That will make consistent command line parsing a bit easier to do.

I had a look at this patch, and I am a little confused. What is in your
videotypes table? Mine contains file extensions, not video types
returned by mplayer, which I think means they're not going to be usable
here. mplayer will return the codec, as opposed to the file extension.

I do like your approach though, so perhaps there is a different table
which contains this information? Before I noticed this I produced the
attached, slightly tweaked version of your patch. Basically all I
changed was code style, and adding a unit test.

Mikal
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: videotypes.patch
URL: <http://lists.stillhq.com/pipermail/mythnettv-stillhq.com/attachments/20090119/c60b9e60/attachment.txt>